Skip to content

fix: allow providing custom query key to TanStack Query #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: allow providing custom query key to TanStack Query #1709

wants to merge 2 commits into from
+109 −0

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Feb 13, 2025

No description provided.

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d09d655

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 7:40am

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 57.06%. Comparing base (f017284) to head (d09d655).

Files with missing lines Patch % Lines
...pi-ts/src/plugins/@tanstack/query-core/queryKey.ts 0.00% 23 Missing ⚠️
...ugins/@tanstack/query-core/infiniteQueryOptions.ts 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
- Coverage   57.13%   57.06%   -0.08%     
==========================================
  Files         191      191              
  Lines       25729    25763      +34     
  Branches     1913     1913              
==========================================
  Hits        14701    14701              
- Misses      11019    11053      +34     
  Partials        9        9
Flag Coverage Δ
unittests 57.06% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iffa
Copy link

iffa commented Jun 10, 2025

@mrlubos just curious, what's the status of this (or a similar implementation)?

@omridevk omridevk mentioned this pull request Aug 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrlubos @iffa